Fixing issue where GCC fails to report compile errors when non-verbose #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of the GCC compiler is such that the toolchain regex sometimes got hung up on the ':' charcter being printed in front of the drive letter when running on Windows. This PR changes the matching logic to be more flexible by using 'search' to check the entire string for a match, not just the beginning of the string.
Contributor
Contributor
|
Bump, any update? |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the GCC compiler is such that the toolchain regex sometimes
got hung up on the
:charcter being printed in front of the drive letter whenrunning on Windows. This PR changes the matching logic to be more flexible
by using
searchto check the entire string for a match, not just thebeginning of the string.
An example of where the current implementation fails is on this PR: #2422
The CI failure is visible here (scroll to the bottom): http://10.118.12.43:8081/job/build_matrix/270/target=KL25Z,toolchain=GCC_ARM/console
You can see the tools didn't print the error here. This PR should fix this issue.